Skip to content

Comments

Refactor, RDFJS, Caching, tests and config#24

Open
mielvds wants to merge 222 commits intodbcls:mainfrom
viaacode:main
Open

Refactor, RDFJS, Caching, tests and config#24
mielvds wants to merge 222 commits intodbcls:mainfrom
viaacode:main

Conversation

@mielvds
Copy link

@mielvds mielvds commented May 11, 2022

I was planning to split this, but I progessed too much. I'll just leave this PR open, up to you if you want to merge and when.

Changes:

  • Refactors the code to a dedicated lib dir, etc.
  • Switches to using RDFJS types internally instead of custom
  • Adds some documentation in the code where possible
  • Upgrades most packages
  • uses Zazuko's sparql-http-client instead of plain fetch
  • Adds caching of Resource entries (and thus SPARQL endpoint results)
  • Adds a json config file to configure sparql endpoints in a more extensive way (needed for non-public endpoints)
  • Adds an alternative method to connect GraphQL types with templates by using directives
  • Updates the README.md
  • Adds unittests

mielvds and others added 30 commits November 18, 2021 15:38
@mielvds
Switches fetch for SparqlClient and Triple interface for RDFJS types.
fe2c774
@mielvds
Fixes wrong import of sparqlclient
899d44f
@mielvds
Fixes grouping according to subject
3fc620f
@mielvds
Move client instantiation outside to Resource construction method
a920636
@mielvds
Moved files to lib folder
a76fe1f
@mielvds
Replaces promise chain with await
3b3d81d
@mielvds
Adds comments and small refactoring
787aa3f
@mielvds
moved handlebars config elsewhere
5563cbf
@mielvds
DEV-1820 Changes readme to correct input
0d76260
@mielvds
Splits off handlebars config
9ac2b12
@mielvds
Update npm packages
bec0685
@mielvds
Adds file load function to schema loader
2f13cc0
@mielvds
Finishes loading services config
34b481d
@mielvds
Adds caching of sparql results
bdc0db2
@mielvds
Makes default cache; configurability is for later
1c3c032
@mielvds
Adds unit tests
ec200f8
@mielvds
Adds utils.oneOrMany to unit tests
a96cc59
@mielvds
Adds utils.oneOrMany to unit tests
0cb9c7d
@mielvds
Extends unit tests
58c4420
@mielvds
Merges both configuration methods. Updates readme
e26026d
@mielvds
Make services file optional
daa0281
@violetina
Infra 443 deploy grasp (#1)
ad0ab34 
* INFRA-443_deploy_grasp install , todo add configmap mounts

* dummy commit to test webhook

* add config to template
@mielvds
DEV-1891 Adds rdf-literal lib to extract value
95d318d
@mielvds
Shorten check for embedded
c8b9820
@mielvds
Replace lodash imports
1267d2d
@mielvds
Update lodash version
91da24e
@mielvds
Fix wrong casing in lodash import
43a7bb5
@mielvds
DEV-1882 Add basic test files
d9e1410
@mielvds
DEV-1882 Added unittests schema-loader
7a8798f
@mielvds
DEV-1882 Increase coverage unittests schema-loader
0ec896e
mielvds and others added 30 commits October 26, 2023 09:30
@mielvds
Merge branch 'clarify-auth-tokens' into 'main'
036d2a2 
Fix confusion between client auth headers and config auth settings

See merge request customers/meemoo/grasp!14
@LaurensRietveld @mielvds
Apply 1 suggestion(s) to 1 file(s)
4ec44f6
@mielvds
Merge branch 'triply-main' into KG-174-grasp-aanpassen-om-met-een-max…
f4764aa 
…imum-aantal-triples-om-te-gaan
@mielvds
Resolve promise on fetchBindings
2195c03
@mielvds
Merge branch 'KG-174-grasp-aanpassen-om-met-een-maximum-aantal-triple…
11ef678 
…s-om-te-gaan' into 'main'

Kg 174 grasp aanpassen om met een maximum aantal triples om te gaan

See merge request customers/meemoo/grasp!9
@mielvds
Align README and fix errors
940daa0
@mielvds
Move list type checking to util
35d6fe4
@mielvds
Do not return nulls for list with non-nullable items
12c82cf
@mielvds
Log warning when detecting nulls
3977716
@mielvds
Merge branch 'non-nullable-lists' into 'main'
7936891 
Hide nulls in lists with non nullable items

See merge request customers/meemoo/grasp!15
@LaurensRietveld
Add objects api
d61caa2
@LaurensRietveld
Merge branch 'feature/add-objects' into 'main'
a9c6aed 
Add objects api

See merge request customers/meemoo/grasp!16
@mielvds
Remove unnecessary files
e22437b
@mielvds
Upgrade test node image version
a042e10
@mielvds
Rewrite test Makefile
4720635
@mielvds
Make tests build before running
e200a94
@mielvds
Merge pull request #17 from viaacode/upgrade
ab42e98 
Upgrade to 1.1.2
@mielvds
Release to github and gitlab
e1b51ae
@mielvds
Remove gitlab
d60d09f
@mielvds
Release 1.2.0
021b994
@mielvds
Expand debugging to catch errors in fetchBindings
da65835
@mielvds
Throw error from bindingstream
185af98
@mielvds
Throw error when fetching bindings
04fc4a8
@mielvds
emit all errors on bindingstream
d336518
@mielvds
Change to chained promise
645350c
@mielvds
Add test cases to reproduce error
2651fd3
@mielvds
Fix SPARQL query not resolving promise when HTTP request failes
ed62add
@mielvds
Add PROXY_AUTH_HEADER env var
9582cce
@mielvds
Merge pull request #18 from viaacode/fix-auth-issue
2fa9e8d 
Fix auth issue
@mielvds
Release 1.2.1
c79a995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mielvds @violetina @spacid @LaurensRietveld