Skip to content

refactor: extract logic from playgroundApp into managers#24

Open
barak007 wants to merge 2 commits intomainfrom
barak/refactor-initial-seperations
Open

refactor: extract logic from playgroundApp into managers#24
barak007 wants to merge 2 commits intomainfrom
barak/refactor-initial-seperations

Conversation

@barak007
Copy link
Copy Markdown

This PR separates the logic of project management into it's own class. that class does not depend on any FileSystemHandle it gets the fs for the project in the open project stage. this also means that the compilation service can be opened per project and we can possibly open more then one project at the same time.

I also moved all GUI related things to the main.tsx since the app can be potentially run standalone.

There are few more things to finish after this:

  1. move openFile types to preview manager
  2. get rid of getActiveProject in favor of GUI to handle multiple open projects.
  3. there will be a small degradation of open project time since we are now waiting for the services before rendering,
  4. ProjectHost can be a class and it will save few functions on the manager and cleanup the code even more.

@barak007 barak007 requested a review from AviVahl July 14, 2023 22:47
@barak007
Copy link
Copy Markdown
Author

@AviVahl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant