refactor: extract logic from playgroundApp into managers#24
Open
refactor: extract logic from playgroundApp into managers#24
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates the logic of project management into it's own class. that class does not depend on any
FileSystemHandleit gets thefsfor the project in the open project stage. this also means that the compilation service can be opened per project and we can possibly open more then one project at the same time.I also moved all GUI related things to the
main.tsxsince the app can be potentially run standalone.There are few more things to finish after this:
openFiletypes to preview managergetActiveProjectin favor of GUI to handle multiple open projects.ProjectHostcan be a class and it will save few functions on the manager and cleanup the code even more.