Conversation
468393a to
d953d15
Compare
yondonfu
requested changes
Jan 18, 2026
4134dca to
648ee01
Compare
Signed-off-by: Rafal Leszko <rafal@livepeer.org>
Signed-off-by: Rafal Leszko <rafal@livepeer.org>
648ee01 to
0feb3d1
Compare
Signed-off-by: Yondon Fu <yondon.fu@gmail.com>
Signed-off-by: Yondon Fu <yondon.fu@gmail.com>
Contributor
|
fb9ff00 fixes the black screen issue at the start of all recordings after the first one in a single session by normalizing timestamps so that they start from 0. It also switches MAX_FPS back to 60 to avoid affecting other streaming logic and instead introduces a RECORDING_MAX_FPS value set to 30 (which is what MediaRecorder uses as a hardcoded value) and when recording drops frames if they come faster than this value. 40e455f adjusts spacing for buttons in ExportDialog which felt very cramped previously. |
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Env variables
RECORDING_ENABLEDtruefalse, recording is disabled.RECORDING_MAX_LENGTH1h1h,30m,120s, or plain seconds (e.g.,3600)RECORDING_STARTUP_CLEANUP_ENABLEDtrueAssumptions / Comments
aiortc.contrib.media.MediaRecorder.Recording input may be tricky because of the pause/resume (we don't pause input stream!)
30because60FPS won't work with MediaRecorder, because MediaRecorder calculates PTS/DTS on its own and if we start delivering frames at60FPS, it fails because PTS/DTS are duplicatedDemo with comments
demo_recording.mp4
fix #56