Add error handling for audit logs and cache operations#1
Merged
Conversation
Previously, cache errors in the evaluate handler were silently discarded (flag, _ := h.cache.GetFlag), which hid connection errors, serialization errors, and Redis outages. Similarly, audit log insertion errors in the flag handler were unchecked, meaning failures from Postgres pressure or full tables would go unnoticed. Now all cache and audit log errors are logged via log.Printf so operators can detect when Redis is unhealthy or audit data is being lost. https://claude.ai/code/session_01JDqcjWMkkrAyY2CxALpmm3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds proper error handling for audit log insertions and cache operations throughout the flag handler, replacing silent failures with logged errors.
Key Changes
logimport to bothflags.goandevaluate.goInsertAuditLog()calls in error checks across all flag operations (Create, Update, Delete, Toggle) with contextual loggingInvalidateFlag()calls in error checks in Update, Delete, and Toggle operations with loggingGetFlag()andSetFlag()cache operations in the Evaluate handler with error checks and logginglog.Printf()including the operation type and affected flag key for debuggingImplementation Details
https://claude.ai/code/session_01JDqcjWMkkrAyY2CxALpmm3