Skip to content

Upgrade nan to 2.10+ for node 10.#31

Open
jeffhung wants to merge 1 commit intodavidtsai:masterfrom
jeffhung:node10-nan
Open

Upgrade nan to 2.10+ for node 10.#31
jeffhung wants to merge 1 commit intodavidtsai:masterfrom
jeffhung:node10-nan

Conversation

@jeffhung
Copy link
Copy Markdown

Upgrade nan to 2.10+ so node-geoip2 could build in node 10.

Otherwise, will encounter the following error:

  CXX(target) Release/obj.target/unix_dgram/src/unix_dgram.o
In file included from ../src/unix_dgram.cc:5:
In file included from ../../nan/nan.h:190:
../../nan/nan_maybe_43_inl.h:88:15: error: no member named 'ForceSet' in 'v8::Object'
  return obj->ForceSet(GetCurrentContext(), key, value, attribs);
         ~~~  ^

See: nodejs/nan#763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants