Open
Conversation
This is working okay, although it doens't really work smoothly for the API based login and the http command based login isn't great, as it requires the user to copy and past token around. Compared to ldap which just logs the user in. So still some work to do here to smooth out the user experience.
This solves the problem that what was implemented was actually authenticating the application and not the user like expected. It worked but it required that the user input a code. This solves that problem so that when you click the login link, if you are already logged in with you SSO provider you'll just automatically log in to the HTTP Server. Likewise if you use the bluesky queueserver api, when you call RM.Login you'll automatically be logged in, no user interaction required.
These should correct some of the problems in the last CI workflow. I moved the LDAP and docker image into the continuous_integration folder so it matches tiled.
Owner
Author
|
The last run of the unit tests showed what appeared to be a unit test design issue and not something related to the tests I added. I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This includes the changes needed to get this working with MS Entra. These changes would have been necessary regardless of the authenticator and much of the code closely resembles what exists in tiled's authentication.py file.
This will support both client credential flow and device auth flows.
Motivation and Context
We wanted support for Entra.
Summary of Changes for Release Notes
Added endpoints required to properly support OIDC authentication flows.
Fixed
Added
Added endpoints required to properly support OIDC authentication flows.
Changed
Removed
How Has This Been Tested?
Tested using MS entra and an authorized application setup in Azure. The application was configured
with the following redirect URLS:
And then the following config setup for the HTTPserver:
Then it was possible to login using this endpoint
http POST http://localhost:60610/api/auth/provider/entra/authorizeand also with the latest queueserver-api changes to support external auth.