Skip to content

Add rolldown-vite 7.2.3+ support #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sapphi-red wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add rolldown-vite 7.2.3+ support #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- run: pnpm playwright install --with-deps
- name: update overrides to use rolldown-vite and re-install
run: |
jq '.pnpm.overrides.vite = "npm:rolldown-vite@^7.0.1"' package.json > package.tmp.json
jq '.pnpm.overrides.vite = "npm:rolldown-vite@^7.2.5"' package.json > package.tmp.json
mv package.tmp.json package.json
pnpm i --no-frozen-lockfile
- run: pnpm -r test:e2e
Expand Down
8 changes: 5 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export const nodePolyfills = (options: PolyfillOptions = {}): Plugin => {
},
...Object.keys(shimsToInject).length > 0
? isRolldownVite
? { inject: shimsToInject }
? { transform: { inject: shimsToInject } }
: { plugins: [inject(shimsToInject)] }
: {},
},
Expand All @@ -249,14 +249,16 @@ export const nodePolyfills = (options: PolyfillOptions = {}): Plugin => {
],
...isRolldownVite
? {
rollupOptions: {
define: defines,
rolldownOptions: {
resolve: {
// https://github.com/niksy/node-stdlib-browser/blob/3e7cd7f3d115ac5c4593b550e7d8c4a82a0d4ac4/README.md?plain=1#L150
alias: {
...polyfills,
},
},
transform: {
define: defines,
},
plugins: [
{
name: 'vite-plugin-node-polyfills:optimizer',
Expand Down