fixed angular-table.js to work with angular 1.2+

[marknutter]

This should fix angular-table.js to work with angular 1.2+

[AlJohri]

+1 can this PR be merged? @davidjnelson

[davidjnelson]

Thanks @marknutter for fixing this!

[AlJohri]

Thanks for merging @davidjnelson, when you get a chance can you update the dependency in bower.json to ~1.2.0

https://github.com/davidjnelson/angular-table/blob/master/bower.json#L5

[davidjnelson]

np @AlJohri ! I am testing the change now. This will be much better when I finally finish 1.1.0 and have unit tests. When manually testing on angular 1.0.7, it doesn't look like the merged version works :-1

[AlJohri]

I might be wrong, but I don't think the merged version will work on 1.0.7.

I think this line 7938dd3#diff-50787cbd9a16c1fa7beb0d70e977dc3fL319

is a breaking change (required for 1.2).

[davidjnelson]

ya, good call @AlJohri . Looks like there is some weird spacing above the first row in the demo too for some reason, and also the handleRowSelection isn't working. hmm... I'll need to sort these out and test more before I push it to bower and release this as angular-table 1.0.1.

[davidjnelson]

and thanks @AlJohri for the push to merge this. sorry it's taken so long!

[AlJohri]

thanks for being on top of this! I just got sick of ng-grid an hour ago and got on the prowl for alternatives, haha.

if you have a few minutes, I'm trying to debug an error I mention in the other open PR #28 (comment).

[davidjnelson]

@AlJohri ya the headers misaligning sporadically is an issue I noticed some time ago and have been meaning to fix. I should just sit down this weekend and knock out 1.1.0 - I keep meaning to.

1.1.0 will be MUCH simpler due to issue #1459 in angular getting merged in the latest release 1.2.13 romantic-transclusion (I love the angular release names!! :-) All of the manual compiling stuff won't even be needed (which is awesome!).

Thanks for your interest in angular-table, it's inspiring me :-) It's 2am here in mountain view, but I will see what I can do tomorrow and over the weekend.

[AlJohri]

Sweet. Really excited for 1.1.0 as well.

I was actually referring to the error causing the table's height to be 0 even after the model's data is updated via AJAX.

<div class="angularTableTableContainer" style="height: 0px;">

Anyway, good luck!

[AlJohri]

Hey! @davidjnelson romantic-transclusion has been released https://github.com/angular/angular.js/releases/tag/v1.2.13

was wondering if you got a chance to work on 1.1.0? do you have a branch for it anywhere?

Also, when you get a chance, can you accept this PR? --> #40

[davidjnelson]

Hi Al! I am happy about romantic transclusion as well. I started work on 1.1 a while back, I believe there's a branch. I've had a tough time with pr's since there are no tests. I'd love help with 1.1 if you are interested! Thanks so much, this is awesome.

[AlJohri]

I couldn't find the 1.1 branch in this repository if that's what you meant :/ I have limited testing experience but would be interested in helping out. Let me know!

I hear http://dalekjs.com/ is great at UI related integration tests even with AngularJS.
see: https://github.com/ryanzec/coding-standards#tests

---

#40 just fixes the current master branch which is broken.