Add wildcard support for data source file paths#45
Open
Conversation
Adds support for glob patterns in data source file paths, allowing users
to match multiple files with a single configuration entry.
Changes:
- Added `_expand_file_pattern()` function to handle wildcards (*, ?, [])
- Updated cmd_run(), cmd_discover(), cmd_explain(), cmd_diag() to process
multiple matched files
- Files are processed in sorted order for consistency
- Improved error messages to show pattern matching results
- Updated documentation with wildcard examples
- Added comprehensive tests for glob pattern functionality
Example usage:
```yaml
data_sources:
- name: AMEX
file: data/amex*.csv # Matches amex-2024.csv, amex-2025.csv, etc.
format: "{date:%m/%d/%Y},{description},{amount}"
```
Based on PR #44 by @vechiato with added tests.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PR Build AvailableVersion: Install from this PRLinux / macOS: curl -fsSL https://raw.githubusercontent.com/davidfowl/tally/main/docs/install-pr.sh | bash -s -- 45Windows PowerShell: iex "& { $(irm https://raw.githubusercontent.com/davidfowl/tally/main/docs/install-pr.ps1) } 45"Manual download: View workflow run and download artifacts. Requirements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for glob patterns in data source file paths, allowing users to match multiple files with a single configuration entry.
Based on PR #44 by @vechiato, with added tests for cross-platform verification.
Changes
_expand_file_pattern()function to handle wildcard patterns (*,?,[])cmd_run(),cmd_discover(),cmd_explain(), andcmd_diag()to process multiple matched filesExample Usage
Test Plan
Closes #44
🤖 Generated with Claude Code