Skip to content

fix(python): commit transaction after creating lamp #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davideme merged 1 commit into from
Feb 22, 2026
Merged

fix(python): commit transaction after creating lamp #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/python/src/openapi_server/repositories/postgres_lamp_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ async def create(self, lamp_entity: LampEntity) -> LampEntity:

self._session.add(db_lamp)
await self._session.flush()
await self._session.commit()
await self._session.refresh(db_lamp)
Comment on lines 58 to 61
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage gap: the existing PostgresLampRepository integration tests exercise create() and then get() within the same SQLAlchemy session/transaction, which would still pass even if create() only did flush() (the root cause described in the PR). To prevent regressions, add a test that creates a lamp, closes the session/request, and then uses a new session/repository instance to get() the lamp and assert it is found.

Copilot generated this review using guidance from repository custom instructions.

return self._to_entity(db_lamp)
Expand Down
Loading