-
Notifications
You must be signed in to change notification settings - Fork 0
Ensure run-image stack matches builder in Cloud Build #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
353ebf1
Add root run Dockerfile
davideme 2f95294
chore(java): add original cloudbuild config
davideme 211615b
build(java): use custom run image for pack build
davideme 917e506
fix(java): align buildpack run image with google-22 stack
davideme 0bb5dc6
merge: integrate origin/main into java run-image stack fix branch
davideme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| FROM gcr.io/buildpacks/gcp/run | ||
| FROM gcr.io/buildpacks/google-22/run | ||
| USER root | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the container
USERtorootin the runtime image unnecessarily grants full privileges inside the container, increasing the impact of any code execution or container escape vulnerability. If application code or dependencies are compromised, an attacker would gain root-level control of the container, which is particularly risky in Cloud Run and other multi-tenant environments. Prefer running as the non-root user provided bygcr.io/buildpacks/google-22/runor another dedicated unprivileged user, and grant elevated capabilities only where strictly necessary.