[Java] Implement effective pagination for GET /v1/lamps#380
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements effective pagination for the Java GET /v1/lamps endpoint, ensuring list responses are bounded and cursor/pageSize parameters are properly honored. The implementation aligns with the parent issue #372's goal of optimizing API performance by preventing unbounded responses.
Changes:
- Added offset-based cursor pagination with configurable page size (default 25)
- Implemented deterministic ordering (by createdAt, then by id) for consistent pagination
- Ensured in-memory repository behavior matches database semantics (active-only filtering and stable sort order)
- Added comprehensive test coverage for pagination scenarios including edge cases
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/java/src/main/java/org/openapitools/controller/LampsController.java |
Updated listLamps endpoint to parse cursor parameter, call paginated service method, and build response with hasMore/nextCursor fields |
src/java/src/main/java/org/openapitools/service/LampService.java |
Added PagedLampsResult record and findAllActivePage method with OffsetBasedPageRequest implementation for cursor-based pagination |
src/java/src/main/java/org/openapitools/repository/impl/InMemoryLampRepository.java |
Updated findAll(Pageable) to filter deleted lamps and sort by createdAt+id for consistency with JPA implementation |
src/java/src/test/java/org/openapitools/controller/LampsControllerTest.java |
Added tests for paginated responses, terminal pages, and invalid cursor handling |
src/java/src/test/java/org/openapitools/service/LampServiceTest.java |
Added tests for hasMore/nextCursor logic, terminal pages, and pageSize validation |
src/java/src/test/java/org/openapitools/repository/LampRepositoryTest.java |
Added tests for active-only filtering and deterministic ordering in paginated queries |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Closes #374