Skip to content

Mvs 738 create new client in timetap#249

Open
benjf wants to merge 8 commits intoDevelopmentfrom
MVS-738-create-new-client-in-timetap
Open

Mvs 738 create new client in timetap#249
benjf wants to merge 8 commits intoDevelopmentfrom
MVS-738-create-new-client-in-timetap

Conversation

@benjf
Copy link
Collaborator

@benjf benjf commented Apr 14, 2021

💾 [Code Check]

Make sure you've checked/done the following before making this PR!

  • Does your code build/run?
  • Does your design approach make sense?
  • Does your work achieve the intention of the card?
  • Does your code have any unintentional side effects -- have you tested a full workflow & checked the logic branches you touched?
  • Did you make a unit test for your code (as appropriate)?
  • Is your branch relatively up to date with the Development branch (within ~2 commits)
  • Have you moved the card to "Needs QA" in Jira

🐬 [JIRA Sprint Card]

https://mass-immunization-system.atlassian.net/browse/MVS-

📰 [Work Description]

Add a couple of sentences describing what you did here

🚦 [Testing/QA Notes]

Describe what steps you took to test and verify operation of this update

patientID.resourceId = createdPatient.data.id;

// Create the new Patient/Client record in TimeTap
await tt_service.createTimetapClient(createdPatient.data);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be wrapping all this in a try/catch or a Transaction type logic so that if either our FHIR write or the TimeTap write fails, then we can throw an error back to front end without creating random orphaned records?

@thespaniard514
Copy link
Collaborator

Also, please update the .env.template to include fake TT key, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants