This repository was archived by the owner on Jul 29, 2021. It is now read-only.
implements godoc.CommandLine as writeOutput#26
Open
packrat386 wants to merge 1 commit intodavecheney:masterfrom
Open
implements godoc.CommandLine as writeOutput#26packrat386 wants to merge 1 commit intodavecheney:masterfrom
packrat386 wants to merge 1 commit intodavecheney:masterfrom
Conversation
This has been removed from the main godoc package, but it just uses exported functionality of that package plus some helper functions. This imports that functionality internally withsome cleanup.
|
This works for me. Thanks @packrat386! |
nadilas
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been removed from the main godoc package, but it just uses
exported functionality of that package plus some helper
functions. This imports that functionality internally with some
cleanup.
I'm not certain if we want to support all the functionality the original version of this long term, but this at least gets us building against the most recent version of godoc.