Make migrations:run output explicit about dry runs#47
Open
joeydebreuk wants to merge 1 commit into
Open
Conversation
With --dry-run, the fork, model creation and migration steps log the same messages as a real run, so it looks like changes were applied. Mark each message with the dry-run state instead.
Member
|
Good idea, thanks! I'll pass this along to the devs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--dry-run,migrations:runprints the same messages as a real run:This looks like the migrations were applied, while nothing happened.
After this change:
The fork and migration-model spinners get a
(dry run, skipped)suffix for the same reason. No behavior changes, only log output.