Skip to content

CNDB-16330: remove sync lock in PartialLifecycleTransaction::trackNewWritten #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbornet merged 2 commits into from
Jan 20, 2026
Merged

CNDB-16330: remove sync lock in PartialLifecycleTransaction::trackNewWritten #2181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d354a
CNDB-16330: remove sync lock in PartialLifecycleTransaction::trackNew…
cbornet Dec 17, 2025
1d946f4
Add comment
cbornet Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/java/org/apache/cassandra/db/lifecycle/LifecycleNewTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ public interface LifecycleNewTracker
void trackNew(SSTable table);

/**
* Called when a new sstable and its indexes bave been fully written
* Called when a new sstable and its indexes have been fully written.
* Implementation must be thread safe and not alter the state of the transaction.
*
* @param table - the newly written sstable to be tracked
*/
default void trackNewWritten(SSTable table)
Expand Down
6 changes: 2 additions & 4 deletions src/java/org/apache/cassandra/db/lifecycle/PartialLifecycleTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,8 @@ public void trackNew(SSTable table)
public void trackNewWritten(SSTable table)
{
throwIfCompositeAborted();
synchronized (mainTransaction)
{
mainTransaction.trackNewWritten(table);
}
// Beware: not synchronized. Thread safety shall be ensured in the main transaction trackNewWritten.
mainTransaction.trackNewWritten(table);
}

@Override
Expand Down