CNDB-16252: Add IndexComponentsImpl#tmpFileFor to allow vector CompactionGraph to index multiple columns#2177
Merged
michaeljmarshall merged 2 commits intomainfrom Dec 19, 2025
Merged
Conversation
…tionGraph to index multiple columns
Checklist before you submit for review
|
|
❌ Build ds-cassandra-pr-gate/PR-2177 rejected by Butler2 regressions found Found 2 new test failures
Found 1 known test failures |
driftx
pushed a commit
that referenced
this pull request
Apr 17, 2026
…tionGraph to index multiple columns (#2177) ### What is the issue Fixes https://github.com/riptano/cndb/issues/16252 ### What does this PR fix and why was it fixed Add a new method to the `IndexComponents.ForWrite` interface named `tmpFileFor`. The new method is expected to create temporary files that are namespaced to the index build. This fixes an issue in the `CompactionGraph` where we incorrectly created temp files with the same name in such a way that they collided. Now the files have the column name and the build id, so they will be properly namespaced while maintaining some form of meaningful name.
driftx
pushed a commit
that referenced
this pull request
Apr 20, 2026
…tionGraph to index multiple columns (#2177) Fixes riptano/cndb#16252 Add a new method to the `IndexComponents.ForWrite` interface named `tmpFileFor`. The new method is expected to create temporary files that are namespaced to the index build. This fixes an issue in the `CompactionGraph` where we incorrectly created temp files with the same name in such a way that they collided. Now the files have the column name and the build id, so they will be properly namespaced while maintaining some form of meaningful name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
Fixes https://github.com/riptano/cndb/issues/16252
What does this PR fix and why was it fixed
Add a new method to the
IndexComponents.ForWriteinterface namedtmpFileFor. The new method is expected to create temporary files that are namespaced to the index build. This fixes an issue in theCompactionGraphwhere we incorrectly created temp files with the same name in such a way that they collided. Now the files have the column name and the build id, so they will be properly namespaced while maintaining some form of meaningful name.