Skip to content

CNDB-15920: Add cassandra.sai.metrics.table_state.enabled flag to be able to enable/disable TableStateMetrics#2119

Merged
ekaterinadimitrova2 merged 2 commits intomainfrom
c15920
Jan 12, 2026
Merged

CNDB-15920: Add cassandra.sai.metrics.table_state.enabled flag to be able to enable/disable TableStateMetrics#2119
ekaterinadimitrova2 merged 2 commits intomainfrom
c15920

Conversation

@ekaterinadimitrova2
Copy link
Copy Markdown

@ekaterinadimitrova2 ekaterinadimitrova2 commented Nov 11, 2025

What is the issue

...
We want to be able to enable/disable TableStateMetrics.

What does this PR fix and why was it fixed

...
Add a flag to be able to do that - cassandra.sai.metrics.table_state.enabled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 11, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@ekaterinadimitrova2
Copy link
Copy Markdown
Author

The two newly exposed and not used metrics are needed and tested in CNDB, thus the test coverage is below 100%.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 3, 2025

@ekaterinadimitrova2
Copy link
Copy Markdown
Author

Butler marked as regressions the below failures:
testContentionMetrics - already has a ticket for the same failure
org.apache.cassandra.io.util.PrefetchingRebuffererTest.testNonSequentialAccess - it doesn't seem related, it doesn't fail locally, I opened a ticket
haversineBenchmark - it doesn't seem related, it doesn't fail locally, I opened a ticket
The rest are known timeouts from CI which we have a ticket about.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 7, 2026

@cassci-bot
Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2119 rejected by Butler


2 regressions found
See build details here


Found 2 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorCompaction100dTest.testZeroOrOneToManyCompaction[dc false] NEW 🔴 0 / 19
o.a.c.index.sai.cql.VectorSiftSmallTest.testMultiSegmentBuild[db false] REGRESSION 🔴 0 / 19

Found 5 known test failures

@ekaterinadimitrova2 ekaterinadimitrova2 merged commit 4be521d into main Jan 12, 2026
489 of 498 checks passed
@ekaterinadimitrova2 ekaterinadimitrova2 deleted the c15920 branch January 12, 2026 20:43
driftx pushed a commit that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants