Serialize nonempty dicts as lists-of-pairs for untyped table insertion#95
Closed
Serialize nonempty dicts as lists-of-pairs for untyped table insertion#95
Conversation
…les, unless they are empty
Collaborator
|
Will become a part of #92 |
Collaborator
Author
|
@toptobes sorry for not including these right away! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96 .
As remarked by @skedwards88 , untyped table insertion seems not to serialize correctly (which raises API exceptions for non-string keys).
This PR aims at fixing this. To do so, a new converter is created, specific to the case, and injected when needed in the serialization stack. Note this is serialization only (no deserialization).
I think this works as intended. The attached tests (which should be followed by manual payload inspection in the logs) ensure that:
{}as they should (as per Writing empty maps to Tables fails because of[]for non-string keys #57 already)Tests (ahem, paste them somewhere to run them):