feat: allow API endpoint URLs to be used as database references#291
Open
erichare wants to merge 1 commit intodatastax:mainfrom
Open
feat: allow API endpoint URLs to be used as database references#291erichare wants to merge 1 commit intodatastax:mainfrom
erichare wants to merge 1 commit intodatastax:mainfrom
Conversation
Parses the database UUID from Astra endpoint URLs of the form: https://<uuid>-<region>.apps.astra*.datastax.com[/...] No change to existing internals - DbRef.parse() now checks for an HTTP(S) URL first, extracts the 36-char UUID prefix from the hostname if present, and falls through to the existing UUID/name logic otherwise. Closes datastax#289 Co-Authored-By: Oz <oz-agent@warp.dev>
Collaborator
|
Thanks for the PR! Just to let you know though Also I was planning on adding a "preferred region" functionality since the endpoint may contain a region too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parses the database UUID from Astra endpoint URLs of the form:
https://-.apps.astra*.datastax.com[/...]
No change to existing internals - DbRef.parse() now checks for an HTTP(S) URL first, extracts the 36-char UUID prefix from the hostname if present, and falls through to the existing UUID/name logic otherwise.
Closes #289