[CFX-4801] Detect template using answers or cli directories
#341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriyhrytsyuk
changed the title
answers or cli directories
yuriyhrytsyuk
force-pushed
the
yhr/CFX-4801-template-detection-both
branch
2 times, most recently
from
bebdec5 to
632ae09
Compare
yuriyhrytsyuk
force-pushed
the
yhr/CFX-4801-template-detection-both
branch
from
632ae09 to
6007c6f
Compare
Contributor
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
Contributor
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
Contributor
|
❌ Some smoke tests failed. ❌ Linux: cancelled |
Contributor
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
Contributor
|
✅ All smoke tests passed! ✅ Linux: success |
yuriyhrytsyuk
force-pushed
the
yhr/CFX-4801-template-detection-both
branch
from
bd61a7e to
08bc512
Compare
Contributor
|
❌ Some smoke tests failed. ❌ Linux: cancelled |
yuriyhrytsyuk
force-pushed
the
yhr/CFX-4801-template-detection-both
branch
from
3d4e81b to
04a69d9
Compare
yuriyhrytsyuk
force-pushed
the
yhr/CFX-4801-template-detection-both
branch
from
04a69d9 to
1dcbb78
Compare
Contributor
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
Contributor
|
✅ All smoke tests passed! ✅ Linux: success |
ajalon1
reviewed
Jan 29, 2026
internal/repo/detect.go
Outdated
Comment on lines
66
to
78
| if fsutil.DirExists(filepath.Join(dir, DataRobotTemplateDetectAnswersPath)) { | ||
| return true | ||
| } | ||
|
|
||
| entries, err := os.ReadDir(filepath.Join(dir, DataRobotTemplateDetectCliPath)) | ||
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| // Older versions were incorrectly creating state.yaml file outside of template directories | ||
| // return true if any file other than state.yaml exists in .datarobot/cli | ||
| return slices.ContainsFunc(entries, func(entry os.DirEntry) bool { | ||
| return entry.Name() != "state.yaml" |
Contributor
There was a problem hiding this comment.
Can we add debug logging here? It will be important for us to keep track of these things.
ajalon1
reviewed
Jan 29, 2026
internal/repo/paths.go
Outdated
| DataRobotTemplateDetectPath = ".datarobot/answers" | ||
| // DataRobotTemplateDetectAnswersPath is the path to the answers folder relative to CWD | ||
| DataRobotTemplateDetectAnswersPath = ".datarobot/answers" | ||
| DataRobotTemplateDetectCliPath = ".datarobot/cli" |
Contributor
There was a problem hiding this comment.
Suggested change
| DataRobotTemplateDetectCliPath = ".datarobot/cli" | |
| // path to the CLI folder relative to CWD; some older templates use this rather than answers | |
| DataRobotTemplateDetectCliPath = ".datarobot/cli" |
ajalon1
reviewed
Jan 29, 2026
Contributor
ajalon1
left a comment
ajalon1
left a comment
There was a problem hiding this comment.
I understand where this is coming from but we need to make sure @shreyaag-dr is onboard with this for older template versions, so that she can update the PRD around template root detection.
yuriyhrytsyuk
force-pushed
the
yhr/CFX-4801-template-detection-both
branch
2 times, most recently
from
978e1bf to
ae68b6a
Compare
yuriyhrytsyuk
force-pushed
the
yhr/CFX-4801-template-detection-both
branch
from
ae68b6a to
27d5128
Compare
ajalon1
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RATIONALE
CHANGES
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: If you're an external contributor, the
run-smoke-testslabel won't work. Only maintainers can trigger smoke tests on forked PRs by applying theapproved-for-smoke-testslabel after security review. Please comment requesting maintainer review if you need smoke tests to run.