[CFX-4069] Create state.yaml file only in template dir #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 Smoke tests triggered! Running on Linux and Windows... |
Contributor
|
✅ All smoke tests passed! ✅ Linux: success |
ajalon1
reviewed
Jan 29, 2026
|
|
||
| // Update state for templates setup completion | ||
| _ = state.UpdateAfterTemplatesSetup() | ||
| _ = state.UpdateAfterTemplatesSetup(repoRoot) |
Contributor
There was a problem hiding this comment.
I just want to make sure -- is it possible for repoRoot at this point to NOT be a template directory? Because as I'm reading this we update state.yaml in the same folder as .env.
ajalon1
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RATIONALE
File
.datarobot/cli/state.yamlwas created in current directory regardless of whether it contains template or not.State file is only useful for commands that work with existing template.
CHANGES
Only create state file in application template.
Minor refactoring: leave only needed functions public, make
LastStartfield optional.PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: If you're an external contributor, the
run-smoke-testslabel won't work. Only maintainers can trigger smoke tests on forked PRs by applying theapproved-for-smoke-testslabel after security review. Please comment requesting maintainer review if you need smoke tests to run.