Unify Seq.Syntax assembly references to the shipped version#316
Merged
nblumhardt merged 3 commits intodatalust:devfrom Jan 30, 2024
Merged
Unify Seq.Syntax assembly references to the shipped version#316nblumhardt merged 3 commits intodatalust:devfrom
Seq.Syntax assembly references to the shipped version#316nblumhardt merged 3 commits intodatalust:devfrom
Conversation
KodrAus
approved these changes
Jan 30, 2024
Member
|
Member
Author
|
datalust/seq-app-mail#19 is the PR tracking the upstream Seq.Syntax updates I mentioned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2024.1 app host is failing to load apps that depend on Seq.Syntax; we're unsure of the root cause but need to unblock the final 2024.1 release, so this PR works around the issue by resolving all Seq.Syntax assembly references to the one we ship with
seqcli.I took the opportunity to break a trivial remaining Serilog.Expressions dependency while I was here, since that's very likely the next problem we'll encounter.
Also noting that Seq.Syntax depends on the published Superpower package, while the earlier Serilog.Expressions dependency embedded this.