Include grouped alert query results inline#71
Merged
Conversation
…; major version bump to 2.0.0)
…cuts as these files are edited one by one :-)
Member
Author
|
Ignore whitespace when diffing. .NET 6 is no longer present on build workers; moved to .NET 8 to get the app onto a more modern API surface (Seq 2024+, which covers just about everyone in production usage at this point). Solution and SDK are on .NET 10. |
liammclennan
approved these changes
Jun 4, 2026
KodrAus
reviewed
Jun 4, 2026
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <VersionPrefix>1.0.0</VersionPrefix> | ||
| <TargetFramework>net8.0</TargetFramework> |
Member
There was a problem hiding this comment.
Any reason not to target net10 here?
Member
Author
There was a problem hiding this comment.
Only 2026.1 supports .NET 10, we'd break most consumers of the package.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70