fix: improve column click behavior and change default show mode#18
Merged
Merged
Conversation
- Remove CI workflow references to non-existent @liam-hq/db and @liam-hq/agent packages - Delete agent-deep-modeling.yml workflow (depends on non-existent @liam-hq/agent) - Simplify frontend-ci.yml by removing Supabase-related steps - Fix zoom behavior when clicking columns in diagram (maintain current zoom/position) - Add skipFitView option to selectTable function - Fix zoom behavior when clicking columns in side panel (zoom to 150% if needed, center column) - Change default show mode from TABLE_NAME to KEY_ONLY - Make default show mode configurable via UserEditingProvider props Co-Authored-By: Christian Screen <devteamlead@aicg.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Christian Screen <devteamlead@aicg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Why is this change needed?
This PR addresses several issues:
CI Workflow Cleanup: Removes references to non-existent
@liam-hq/dband@liam-hq/agentpackages that were causing CI failures. Theagent-deep-modeling.ymlworkflow is deleted entirely, andfrontend-ci.ymlis simplified to remove Supabase-related steps.Column Click Zoom Behavior: When clicking a column in the side panel, the diagram now:
Default Show Mode: Changes the default diagram display mode from "Table Name" to "Key Only", which is configurable via the
defaultShowModeprop onUserEditingProvider.Drawer Close Zoom Fix: Prevents the diagram from resetting zoom when closing the table details pane by stopping click event propagation when clicking outside the drawer.
Changes
agent-deep-modeling.ymlworkflow (depends on non-existent packages)frontend-ci.ymlby removing Supabase-related stepsskipFitViewoption toselectTablefunction for future usehandleColumnClickinTableDetail.tsxwith zoom-to-150% logicshowModefrom'TABLE_NAME'to'KEY_ONLY'TableDetailDrawer.tsxto prevent zoom reset on drawer closeHuman Review Checklist
Note: There are pre-existing CI failures (Drizzle parser tests, AppBar.tsx lint error) that exist on the main branch and are unrelated to these changes.
Link to Devin run: https://app.devin.ai/sessions/a4e71b4d945a4ec686fe5e216a5437bf
Requested by: Christian Screen (@christian-screen)