Skip to content

fix: improve column click behavior and change default show mode#18

Merged
christian-screen merged 2 commits into
mainfrom
devin/1769280392-fix-zoom-and-defaults
Jan 24, 2026
Merged

fix: improve column click behavior and change default show mode#18
christian-screen merged 2 commits into
mainfrom
devin/1769280392-fix-zoom-and-defaults

Conversation

@devin-ai-integration
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot commented Jan 24, 2026

Issue

  • resolve: User-reported issues with ERD viewer zoom behavior and default display mode

Why is this change needed?

This PR addresses several issues:

  1. CI Workflow Cleanup: Removes references to non-existent @liam-hq/db and @liam-hq/agent packages that were causing CI failures. The agent-deep-modeling.yml workflow is deleted entirely, and frontend-ci.yml is simplified to remove Supabase-related steps.

  2. Column Click Zoom Behavior: When clicking a column in the side panel, the diagram now:

    • Zooms to 150% if the current zoom is below that threshold
    • Centers the selected table in the viewport
    • Maintains current zoom if already at 150% or higher
  3. Default Show Mode: Changes the default diagram display mode from "Table Name" to "Key Only", which is configurable via the defaultShowMode prop on UserEditingProvider.

  4. Drawer Close Zoom Fix: Prevents the diagram from resetting zoom when closing the table details pane by stopping click event propagation when clicking outside the drawer.

Changes

  • Delete agent-deep-modeling.yml workflow (depends on non-existent packages)
  • Simplify frontend-ci.yml by removing Supabase-related steps
  • Add skipFitView option to selectTable function for future use
  • Add handleColumnClick in TableDetail.tsx with zoom-to-150% logic
  • Change default showMode from 'TABLE_NAME' to 'KEY_ONLY'
  • Add click event listener in TableDetailDrawer.tsx to prevent zoom reset on drawer close

Human Review Checklist

  • Verify zoom behavior when clicking columns in the side panel (should zoom to 150% minimum and center table)
  • Verify zoom behavior when clicking columns in the diagram (should maintain current zoom/position)
  • Verify closing the table details pane does NOT reset the diagram zoom (click outside drawer or use close button)
  • Confirm default show mode is now "Key Only" on initial load
  • Confirm CI workflow removals are appropriate for this fork

Note: There are pre-existing CI failures (Drizzle parser tests, AppBar.tsx lint error) that exist on the main branch and are unrelated to these changes.


Link to Devin run: https://app.devin.ai/sessions/a4e71b4d945a4ec686fe5e216a5437bf
Requested by: Christian Screen (@christian-screen)

- Remove CI workflow references to non-existent @liam-hq/db and @liam-hq/agent packages
- Delete agent-deep-modeling.yml workflow (depends on non-existent @liam-hq/agent)
- Simplify frontend-ci.yml by removing Supabase-related steps
- Fix zoom behavior when clicking columns in diagram (maintain current zoom/position)
- Add skipFitView option to selectTable function
- Fix zoom behavior when clicking columns in side panel (zoom to 150% if needed, center column)
- Change default show mode from TABLE_NAME to KEY_ONLY
- Make default show mode configurable via UserEditingProvider props

Co-Authored-By: Christian Screen <devteamlead@aicg.com>
@devin-ai-integration
Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: Christian Screen <devteamlead@aicg.com>
@christian-screen christian-screen merged commit a9d2f71 into main Jan 24, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant