-
Notifications
You must be signed in to change notification settings - Fork 5
Python packaging and wheel build #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@yarikoptic It is not clear to me why the patch would not apply -- it does for me locally, and it only adds files. Please advice. Update: Applying the patch only fails on windows. The very same patch (against the same sources?) applies cleanly on macos and ubuntu. |
5e667f2 to
0a3cc9f
Compare
Apparently git is touchy to line endings on Windows while applying patches, so we will just modify them in place on windows to guarantee correct ending
=== Do not change lines below ===
{
"chain": [
"47fa1b854c9e94abc0fe7aadb8df8a8cd6525808",
"ff26f850198044041285400f56f451b5a76d95d3",
"424897650eadcbf7c13636064073bde0df7a6eda"
],
"cmd": "make -C .github/workflows/template",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
…ws stopped working
|
this is confusing... it was working ok in some TEMP implementations where I had unix2dos call before applying the patches, and it worked. but now it stopped, uff... dunno ATM. Might later troubleshoot directly in github actions using https://github.com/mxschmitt/action-tmate . At least I added installation/invocation of |

This is WiP. Posting now to see if anything re actions integration would work. The packaging itself has been tested on linux and windows already.