feat(seo): use getDescriptionShort to handle long description #878
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskempf57
requested review from
ThibaudDauce and
maudetes
as code owners
ThibaudDauce
approved these changes
Jan 19, 2026
Contributor
ThibaudDauce
left a comment
ThibaudDauce
left a comment
There was a problem hiding this comment.
removeMarkdown could use processSync to avoid all these computedAsync (I don't know how it will work with the SSR?)
Comment on lines
36
to
39
| export async function getDescriptionShort( | ||
| description: string | null | undefined, | ||
| descriptionShort: string | null | undefined, | ||
| descriptionShort?: string | null | undefined, | ||
| ): Promise<string> { |
Contributor
There was a problem hiding this comment.
Should this function take a Dataset instead? Or a generic object with description and description_short ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
getDescriptionShortto handle the case of a dataset without description.I encountered a reactive issue with the previous solution that I can't reproduce anymore with this new implementation.