Skip to content

Add TLS feature in default ChannelResolver#273

Closed
gabotechs wants to merge 2 commits intomainfrom
gabrielmusat/tls-channel-resolver
Closed

Add TLS feature in default ChannelResolver#273
gabotechs wants to merge 2 commits intomainfrom
gabrielmusat/tls-channel-resolver

Conversation

@gabotechs
Copy link
Copy Markdown
Collaborator

Adds a new tls feature for enriching the default ChannelResolver implementation with TLS features.

This is typically not needed, as communication between workers usually happens within a trusted network, and it's not worth paying the price of encryption/decryption, but adding the option to also account for the most strict setups.

Copy link
Copy Markdown
Collaborator

@NGA-TRAN NGA-TRAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// Using Grafana's public gRPC demo server for testing HTTPS with valid certificates.
// This verifies that our TLS configuration works with real-world endpoints using
// system root certificates.
const URL: &str = "https://grpc-quickpizza.grafana.com:443";
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@gabotechs
Copy link
Copy Markdown
Collaborator Author

Not doing it for now

@gabotechs gabotechs closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants