add: automatically detect filetype without rely on ending#25
Open
matthias-Q wants to merge 1 commit intodatafusion-contrib:mainfrom
Open
add: automatically detect filetype without rely on ending#25matthias-Q wants to merge 1 commit intodatafusion-contrib:mainfrom
matthias-Q wants to merge 1 commit intodatafusion-contrib:mainfrom
Conversation
matthias-Q
force-pushed
the
detect_file_type
branch
from
3f43f44 to
ce01f58
Compare
matthias-Q
force-pushed
the
detect_file_type
branch
from
ce01f58 to
711952d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the lib file-format to detect the filetype using the magic number. for Plaintext files like json/csv, we fall back to the file ending variant.
This addresses the issue #24