Skip to content

Add custom_attributes struct to metadata #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulmadanahalli wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add custom_attributes struct to metadata #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b17256
add custom_attributes struct to metadata & incremental table tests
rahulmadanahalli Dec 17, 2025
523e9da
fix incremental table tests & add view & table test
rahulmadanahalli Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions core/actions/incremental_table_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ actions:
onSchemaChange: "SYNCHRONIZE",
metadata: {
overview: "incremental table overview",
customAttributes: {
fields: {
priority: { stringValue: "high" }
}
}
},
}
`;
Expand Down Expand Up @@ -186,8 +191,13 @@ SELECT 1`
key: "val"
},
metadata: {
overview: "incremental table overview"
}
overview: "incremental table overview",
customAttributes: {
fields: {
priority: { stringValue: "high" }
}
}
},
}
}
]);
Expand Down
13 changes: 12 additions & 1 deletion core/actions/table_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ actions:
hermetic: true,
metadata: {
overview: "table overview",
customAttributes: {
fields: {
priority: { stringValue: "high" }
}
}
}
}`;

Expand Down Expand Up @@ -169,7 +174,13 @@ SELECT 1`
key: "val"
},
metadata: {
overview: "table overview"
overview: "table overview",

customAttributes: {
fields: {
priority: { stringValue: "high" }
}
}
}
}
}
Expand Down
12 changes: 11 additions & 1 deletion core/actions/view_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ actions:
${exampleBuiltInAssertions.inputAssertionBlock}
metadata: {
overview: "view overview",
customAttributes: {
fields: {
priority: { stringValue: "high" }
}
}
},
}`;
[
Expand Down Expand Up @@ -164,7 +169,12 @@ SELECT 1`
key: "val"
},
metadata: {
overview: "view overview"
overview: "view overview",
customAttributes: {
fields: {
priority: { stringValue: "high" }
}
}
},
},
materialized: true
Expand Down
4 changes: 4 additions & 0 deletions protos/configs.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ option java_multiple_files = true;

option go_package = "github.com/dataform-co/dataform/protos/dataform";

import "google/protobuf/struct.proto";

// Workflow Settings defines the contents of the `workflow_settings.yaml`
// configuration file.
message WorkflowSettings {
Expand Down Expand Up @@ -266,6 +268,8 @@ message ActionConfig {
message Metadata {
// A detailed description of the data object.
string overview = 1;
// Custom attributes of the data object.
google.protobuf.Struct custom_attributes = 2;
}

message ViewConfig {
Expand Down
2 changes: 2 additions & 0 deletions protos/core.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ syntax = "proto3";
package dataform;

import "protos/configs.proto";
import "google/protobuf/struct.proto";

option java_package = "com.dataform.protos";
option java_outer_classname = "CoreMeta";
Expand Down Expand Up @@ -110,6 +111,7 @@ message ActionDescriptor {

message Metadata {
string overview = 1;
google.protobuf.Struct custom_attributes = 2;
}
Copy link
Contributor

@kolina kolina Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are attributes is relevant name here?


message ColumnDescriptor {
Expand Down