feat: allow custom icons in call outs#300
Open
MustThinkOfAName wants to merge 3 commits intodataesr:masterfrom
Open
feat: allow custom icons in call outs#300MustThinkOfAName wants to merge 3 commits intodataesr:masterfrom
MustThinkOfAName wants to merge 3 commits intodataesr:masterfrom
Conversation
annelhote
requested changes
Nov 22, 2022
desoindx
requested changes
Nov 22, 2022
Collaborator
desoindx
left a comment
desoindx
left a comment
There was a problem hiding this comment.
Can you also update the storybook exemple please ?
MustThinkOfAName
force-pushed
the
addCustomIconsCallouts
branch
from
6ee8027 to
e1fa1e0
Compare
MustThinkOfAName
requested review from
desoindx
and removed request for
annelhote
desoindx
approved these changes
Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Les eslint-disable ne sont normalement pas best practice mais ils me semblent coherent dans ce context