Skip to content

fix: add session rollback after save datasource in chat error #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulleo merged 1 commit into from
Sep 30, 2025
Merged

fix: add session rollback after save datasource in chat error #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions backend/apps/chat/task/llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,10 +495,16 @@ def select_datasource(self):
_engine_type = self.chat_question.engine
_chat.engine_type = _ds.type_name
# save chat
self.session.add(_chat)
self.session.flush()
self.session.refresh(_chat)
self.session.commit()
with self.session.begin_nested():
# 为了能继续记日志，先单独处理下事务
try:
self.session.add(_chat)
self.session.flush()
self.session.refresh(_chat)
self.session.commit()
except Exception as e:
self.session.rollback()
raise e

elif data['fail']:
raise SingleMessageError(data['fail'])
Expand Down