Skip to content

fix(Smart Question): In the conversation window, when there are many… #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataeaseShu merged 1 commit into from
Sep 19, 2025
Merged

fix(Smart Question): In the conversation window, when there are many… #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/views/chat/RecommendQuestion.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const props = withDefaults(
}
)

const emits = defineEmits(['clickQuestion', 'update:currentChat', 'stop'])
const emits = defineEmits(['clickQuestion', 'update:currentChat', 'stop', 'loadingOver'])

const loading = ref(false)

Expand Down Expand Up @@ -134,6 +134,7 @@ async function getRecommendQuestions() {
}
} finally {
loading.value = false
emits('loadingOver')
}
}

Expand Down
10 changes: 7 additions & 3 deletions frontend/src/views/chat/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@
:first-chat="message.first_chat"
@click-question="quickAsk"
@stop="onChatStop"
@loadingOver="loadingOver"
/>
<UserChat v-if="message.role === 'user'" :message="message" />
<template v-if="message.role === 'assistant' && !message.first_chat">
Expand Down Expand Up @@ -286,6 +287,7 @@
:first-chat="message.first_chat"
:disabled="isTyping"
@click-question="quickAsk"
@loadingOver="loadingOver"
@stop="onChatStop"
/>
</template>
Expand Down Expand Up @@ -676,9 +678,11 @@ async function onChartAnswerFinish(id: number) {
getRecommendQuestionsLoading.value = true
loading.value = false
isTyping.value = false
getRecommendQuestions(id).finally(() => {
getRecommendQuestionsLoading.value = false
})
getRecommendQuestions(id)
}

const loadingOver = () => {
getRecommendQuestionsLoading.value = false
}

function onChartAnswerError() {
Expand Down