Open
Conversation
- Add @playwright/test as dev dependency - Create Playwright configuration with baseURL http://localhost:9091 - Add test:playwright npm script that builds, starts server, runs tests, and cleans up - Create editor.spec.js test that verifies: - Editor loads successfully - Form elements visible on left (navigation, inputs) - Preview section visible on right - Include full-page screenshot for visual verification - Test runs in production mode using bin/datacontract-editor.js 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add dedicated test job that runs Playwright tests before deployment - Install Node.js 22 and dependencies with caching - Install Playwright browsers (chromium only for efficiency) - Run test:playwright npm script - Upload test results and screenshots as artifacts (30 day retention) - Make build_and_deploy_job depend on test job passing - Add test-results/ and .preview-server.pid to .gitignore This ensures no deployment happens unless all tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
should this screenshot be published to Git?
Contributor
Author
There was a problem hiding this comment.
good point - visual regression testing should not be part of the test. will remove.
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive Playwright end-to-end testing for the data contract editor and integrates it into the CI/CD workflow, ensuring the application works correctly in production mode before deployment.
Changes
Testing Infrastructure
@playwright/testas a dev dependencyplaywright.config.js)test:playwrightnpm script for automated testingTest Coverage
Created
tests/editor.spec.jsthat verifies:CI/CD Integration
testjob to GitHub Actions workflowbuild_and_deploy_jobnow depends on tests passingTest Script
The
test:playwrightnpm script:bin/datacontract-editor.json port 9091Visual Verification
tests/screenshots/editor-layout.png)Other Improvements
.gitignoreto exclude test artifactsgetValue('schema')instead of parsing YAML (from PR Suggest schema.property for SLA element #13)Test Results
Workflow Flow
Usage
Run tests locally with:
🤖 Generated with Claude Code