fix: emit CREATE VIEW when model type is view in SQL export (#1031)#1119
Open
barry0451 wants to merge 1 commit intodatacontract:mainfrom
Open
fix: emit CREATE VIEW when model type is view in SQL export (#1031)#1119barry0451 wants to merge 1 commit intodatacontract:mainfrom
barry0451 wants to merge 1 commit intodatacontract:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1031
When a model has
type: viewin the data contract YAML, the SQL exporter was unconditionally emittingCREATE TABLE. This change makes the exporter emitCREATE VIEW(orCREATE OR REPLACE VIEWfor Databricks) when the model's physicalType isview, matching the behavior of the dbt exporter.Changes:
_to_sql_table(), checkmodel.physicalType.lower() == 'view'and swap the DDL keyword accordinglyCREATE OR REPLACE VIEWto align with Databricks best practicesTest:
test_to_sql_ddl_postgres_view()with a dedicated view-based fixture