fix: escape pipe characters in markdown table cells (fixes #832)#1117
Open
barry0451 wants to merge 2 commits intodatacontract:mainfrom
Open
fix: escape pipe characters in markdown table cells (fixes #832)#1117barry0451 wants to merge 2 commits intodatacontract:mainfrom
barry0451 wants to merge 2 commits intodatacontract:mainfrom
Conversation
barry0451
force-pushed
the
fix/issue-832-markdown-table-columns
branch
from
7f698be to
749092a
Compare
barry0451
force-pushed
the
fix/issue-832-markdown-table-columns
branch
from
749092a to
858a474
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jschoedl
requested changes
Apr 2, 2026
| parts.append(array_to_markdown(value_extra)) | ||
| raw = array_to_markdown(value_extra) | ||
| if is_in_table_cell: | ||
| raw = raw.replace("\n", "<br />") |
Collaborator
There was a problem hiding this comment.
Why not replace pipes here as well? Same for line 381 and 384.
… within table cells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extra field values (e.g.,
config,customProperties) contain list-of-dict content with embedded pipe characters, the generated markdown table structure breaks (parser sees more columns than expected).This fix escapes
|as|when rendering list-of-dict extra field values inside table cells inextra_to_markdown().Fixes #832