Convert scatter tile to use getDenomInfo to solve population data bug#5718
Draft
lucyking140 wants to merge 7 commits intodatacommonsorg:masterfrom
Draft
Convert scatter tile to use getDenomInfo to solve population data bug#5718lucyking140 wants to merge 7 commits intodatacommonsorg:masterfrom
lucyking140 wants to merge 7 commits intodatacommonsorg:masterfrom
Conversation
… all tile types (datacommonsorg#5446)" This reverts commit 6b4a631.
…r all tile types (datacommonsorg#5446)" This reverts commit caad5d1.
lucyking140
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the per capita calculations for scatter tiles where if there was population data available from the same facet as the numerator for ANY place, it would be used for all places. This resulted in null population data more often because sometimes this information wasn't available for a place in particular, but there was population data available from other facets.
This was missed in the scatter tile when it was corrected in
getDenomInfo, so I changed the logic here to reuse this helper.