external rules loaded as json with UT#40
Open
sidharthbolar wants to merge 2 commits intodatabrickslabs:masterfrom
Open
external rules loaded as json with UT#40sidharthbolar wants to merge 2 commits intodatabrickslabs:masterfrom
sidharthbolar wants to merge 2 commits intodatabrickslabs:masterfrom
Conversation
Author
|
This implements the enhancement request #4 |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @GeekSheikh
Have extended this library's capability to load rules from an external Json object
Have added the corresponding UT to validate the various Rule Types
It uses circe-json to parse json and defines the custom decoders for the various
rule types initialisation options available to user
It does not support MinMax Rules, however can incorporate that in the next drop
Please review and let me know in case of any feedback