[Python] Support configurable Arrow compression#145
Merged
teodordelibasic-db merged 5 commits intomainfrom Mar 18, 2026
Merged
Conversation
python/rust/src/arrow.rs
Outdated
Comment on lines
+127
to
+128
| #[pyo3(get, set)] | ||
| pub ipc_compression: Option<String>, |
Contributor
There was a problem hiding this comment.
Why did we go with String? Could it be an enum? So we don't have to do any string matching
Contributor
Author
There was a problem hiding this comment.
Done, good idea.
Comment on lines
+22
to
+25
| fn ipc_bytes_to_record_batch(ipc_bytes: &[u8]) -> Result<arrow_array::RecordBatch, RustError> { | ||
| let mut reader = arrow_ipc::reader::StreamReader::try_new(ipc_bytes, None).map_err(|e| { | ||
| RustError::InvalidArgument(format!("Failed to parse Arrow IPC data: {}", e)) | ||
| })?; |
Contributor
There was a problem hiding this comment.
I see a lot of these formatting changes. Were they causing some fmt errors? And if they did, how come we didn't see them before?
Contributor
Author
There was a problem hiding this comment.
Nice catch, we previously didn't run formatting of python/rust/*.rs files and we didn't check their formatting in the CI. I added both.
Signed-off-by: teodor-delibasic_data <teodor.delibasic@databricks.com>
Signed-off-by: teodor-delibasic_data <teodor.delibasic@databricks.com>
Signed-off-by: teodor-delibasic_data <teodor.delibasic@databricks.com>
teodordelibasic-db
force-pushed
the
python-arrow-compression
branch
from
84c5168 to
f4531ef
Compare
elenagaljak-db
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Previous PR missed to add configurable compression type to Python Arrow support.
How is this tested?
Added conversion UTs.