Merged
Conversation
elenagaljak-db
force-pushed
the
elenagaljak-db-all_test
branch
from
c6afaeb to
0a92ebc
Compare
Contributor
teodordelibasic-db
left a comment
teodordelibasic-db
left a comment
There was a problem hiding this comment.
Looks good except the two testing lines 🙂
rust/sdk/src/lib.rs
Outdated
| Ok(stream) => { | ||
| if let Some(stream_id) = stream.stream_id.as_ref() { | ||
| info!(stream_id = %stream_id, "Successfully created new ephemeral stream"); | ||
| info!(stream_id = %stream_id, "Successfully created new ephemeral stream. random line change"); |
|
|
||
| async def main(): | ||
| print("Starting asynchronous ingestion example (Protobuf)...") | ||
| print("Starting asynchronous ingestion example (Protobuf)... random line change") |
Signed-off-by: elenagaljak-db <elena.galjak@databricks.com>
Signed-off-by: elenagaljak-db <elena.galjak@databricks.com>
Signed-off-by: elenagaljak-db <elena.galjak@databricks.com>
elenagaljak-db
force-pushed
the
elenagaljak-db-all_test
branch
from
e384806 to
1bd97ab
Compare
teodordelibasic-db
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
When we change Rust SDK (which is the base of all SDKs) we want to run all tests, not only rust related ones.
How is this tested?
Manually