Skip to content

chore: Avoid copy with ArrayBuilder #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
He-Pin wants to merge 2 commits into from
Closed

chore: Avoid copy with ArrayBuilder #576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1e2e3a
chore: Avoid copy with ArrayBuilder
He-Pin Dec 22, 2025
2ae97d6
.
He-Pin Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions sjsonnet/src/sjsonnet/stdlib/SetModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,27 @@ object SetModule extends AbstractFunctionModule {
val out = new mutable.ArrayBuilder.ofRef[Lazy]
// Set a reasonable size hint - in the worst case (no duplicates), we'll need arrValue.length elements
out.sizeHint(arrValue.length)
var last: Lazy = null
var knownSize = 0
for (v <- arrValue) {
val outResult = out.result()
if (outResult.length == 0) {
if (knownSize == 0) {
out.+=(v)
last = v
knownSize += 1
} else if (keyF.isInstanceOf[Val.False]) {
if (!ev.equal(outResult.last.force, v.force)) {
if (!ev.equal(last.force, v.force)) {
out.+=(v)
last = v
knownSize += 1
}
} else if (!keyF.isInstanceOf[Val.False]) {
} else {
val keyFFunc = keyF.asInstanceOf[Val.Func]
val o1Key = keyFFunc.apply1(v, pos.noOffset)(ev, TailstrictModeDisabled)
val o2Key = keyFFunc.apply1(outResult.last, pos.noOffset)(ev, TailstrictModeDisabled)
val o2Key = keyFFunc.apply1(last, pos.noOffset)(ev, TailstrictModeDisabled)
if (!ev.equal(o1Key, o2Key)) {
out.+=(v)
last = v
knownSize += 1
}
}
}
Expand Down