Skip to content

Conversation

@samikshya-db
Copy link
Collaborator

@samikshya-db samikshya-db commented Dec 15, 2025

Changes :

The changes in this PR :

  1. Add config params for telemetry similar to oss jdbc
  2. Add circuit breaker logic code (Note : this will be integrated at a later point in time)
  3. Keep the lowest level of logging for telemetry (to keep telemetry as silent as possible)

The original design doc was changed to :

  1. Keep config names similar to the ones used in JDBC.
  2. Add more details to circuit breaker logic. (This will be useful from a spec driven development perspective )

@samikshya-db samikshya-db changed the title Add configs + prepare for opt-in (make changes to original plan) Add configs, circuit breaker for telemetry + prepare for opt-in (make changes to original plan) Dec 16, 2025
@samikshya-db samikshya-db marked this pull request as ready for review December 16, 2025 06:57
@samikshya-db samikshya-db changed the title Add configs, circuit breaker for telemetry + prepare for opt-in (make changes to original plan) Add circuit breaker for telemetry + amend design plan to be similar to jdbc Dec 16, 2025
@samikshya-db samikshya-db changed the title Add circuit breaker for telemetry + amend design plan to be similar to jdbc Add circuit breaker for telemetry + amend design plan to be similar to include more details on circuit breaker and config Dec 17, 2025
// Check for enableTelemetry flag (respects server feature flags)
if v, ok := params["enableTelemetry"]; ok {
if v == "true" || v == "1" {
cfg.EnableTelemetry = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does Enabled ultimately store whether telemetry is active or not (final source of truth to check whether telemetry is active - determined based on ForceEnableTelemetry or EnableTelemetry in combination with server flag) ? if so, then shouldn't we update that variable as well here based on the server flag ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants