Add NewLimitIterator to cap iterator output to N items#1555
Open
simonfaltum wants to merge 2 commits intomainfrom
Open
Add NewLimitIterator to cap iterator output to N items#1555simonfaltum wants to merge 2 commits intomainfrom
simonfaltum wants to merge 2 commits intomainfrom
Conversation
Co-authored-by: Isaac Signed-off-by: simon <simon.faltum@databricks.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This was referenced Mar 18, 2026
- Add NEXT_CHANGELOG.md entry for NewLimitIterator - Document divergence from ToSliceN for negative inputs in doc comment - Add HasNext idempotency subtest Co-authored-by: Isaac Signed-off-by: simon <simon.faltum@databricks.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewLimitIterator[T](iter, n)tolistingpackage: a lazy iterator wrapper that yields at most N itemsDeduplicatingIteratorpattern (unexported struct, exported constructor returningIterator[T])n <= 0means no limit (returns inner iterator unchanged)Motivation
The Databricks CLI needs to limit output from paginated list commands (
--limitflag).ToSliceNexists for the slice case, but there's no lazy equivalent for streaming iteration. This fills that gap.Tests
8 new subtests covering: limit below/above total, limit of one, zero/negative as no-op, exhaustion via
Next, error propagation, standardHasNext/Nextloop.