Call resolveHostMetadata on Config init#1542
Merged
hectorcast-db merged 4 commits intomainfrom Mar 16, 2026
Merged
Conversation
Port of Python SDK PR #1318 and discovery URL fix from PR #1332. Extract applyHostMetadata() from resolveHostMetadata() for reuse. Call host metadata resolution during EnsureResolved() for unified hosts, with non-fatal error handling (warns on failure instead of failing). The OIDC endpoint from metadata is now treated as the OIDC root, with /.well-known/oauth-authorization-server appended to form the full discovery URL. Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This was referenced Mar 16, 2026
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Instead of silently ignoring the error from fixHostIfNeeded(), log it as a warning before skipping host metadata resolution. Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
changed the title
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
hectorcast-db
deleted the
hectorcast-db/stack/port/resolve-host-metadata-on-init
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
applyHostMetadata()fromresolveHostMetadata()for reuse during config initEnsureResolved()for unified hosts (gated behindExperimental_IsUnifiedHost), with non-fatal error handling (warns on failure)/.well-known/oauth-authorization-serverappended to form the full discovery URLTest plan
TestEnsureResolved_ResolvesHostMetadata_WhenUnifiedHost— verifies fields populated from metadataTestEnsureResolved_HostMetadataFailure_NonFatal— 500 response, config still resolvesTestEnsureResolved_HostMetadata_NoOidcEndpoint_NonFatal— missing oidc_endpoint, no errorTestEnsureResolved_HostMetadata_MissingAccountIdWithPlaceholder_Warns— template needs account_id but missingresolveHostMetadatatests updated for new discovery URL formatNO_CHANGELOG=true
This pull request was AI-assisted by Isaac.