Fix debug logs showing empty Host for API requests#1525
Open
hectorcast-db wants to merge 2 commits intomainfrom
Open
Fix debug logs showing empty Host for API requests#1525hectorcast-db wants to merge 2 commits intomainfrom
hectorcast-db wants to merge 2 commits intomainfrom
Conversation
API requests use relative paths, so http.NewRequestWithContext leaves r.Host empty. Go copies r.URL.Host into the Host header automatically before sending, so requests reach the correct server — but debug logs read r.Host directly and showed an empty host. Set r.Host explicitly in the visitor alongside r.URL.Host. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com>
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Hector Castejon Diaz <hector.castejon@databricks.com>
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes empty
Hostin debug logs for all API requests (workspace and account level).API requests use relative paths (e.g.
/api/2.0/...), sohttp.NewRequestWithContextleavesr.Hostempty — only requests built from full URLs (like auth token fetches) had it populated. Go silently falls back tor.URL.Hostfor the wire Host header, so requests always reached the correct server. ButRoundTripStringerreadsr.Hostdirectly, making the host appear empty in debug logs.Fix: set
r.Host = url.Hostin the request visitor alongside the existingr.URL.Hostassignment.Tests
Manually verified with
go run ./test/using the UNIFIED profile —Host:now shows correctly in debug logs for all API calls.NO_CHANGELOG=false