-
Notifications
You must be signed in to change notification settings - Fork 27
Fix deadlock by completing futures for upfront-fetched chunk links #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadlock by completing futures for upfront-fetched chunk links #1101
Conversation
Complete link futures for upfront-fetched chunks to prevent deadlock When chunk links are fetched upfront, the corresponding futures were never completed, causing threads to wait indefinitely. Now we complete these futures in the constructor for all pre-fetched chunks.
|
e2e testing that link download service triggers a refresh on expiry when chunk is being downloaded: |
Please add testing details |
|
Why are tests failing? |
Done. |
|
Tests are passing now. |
Description
NO_CHANGELOG=true
Complete link futures for upfront-fetched chunks to prevent deadlock
When chunk links are fetched upfront, the corresponding futures were never completed, causing threads to wait indefinitely. Now we complete these futures in the constructor for all pre-fetched chunks.
Testing
Additional Notes to the Reviewer