Open
Conversation
Test that identity is forwarded correctly through both the Model Serving (ModelServingUserCredentials) and Databricks Apps (direct token) OBO paths using two different service principals and a whoami() UC function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ials WorkspaceClient doesn't accept credential_strategy directly. Use Config object as shown in the existing unit tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…t kwarg The docstring had a typo (credential_strategy vs credentials_strategy). Fixed both the test and the source docstring to use the correct parameter name that WorkspaceClient actually accepts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The SQL current_user() returns the SP's UUID, not its display_name. Compare the two whoami() results against each other instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Invoke pre-deployed Model Serving endpoint and Databricks App as two different SPs, assert each sees their own identity via whoami() tool. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- App fixture: committed agent code so CI redeploys with latest on each run - deploy_serving_agent.py: script to log + deploy ChatModel with OBO to serving endpoint - Warm-start fixture: polls serving endpoint until scaled up before tests - Remove -k TestAppsOBO filter — both Apps and Serving tests run Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Hatch couldn't find the package directory because the project name didn't match any directory. Explicitly list agent_server and scripts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- whoami_serving_agent.py: ResponsesAgent using SQL Statement Execution with ModelServingUserCredentials for OBO - deploy_serving_agent.py: logs with AuthPolicy + deploys with scale_to_zero - Warehouse ID from env var (not hardcoded) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4dfdae7 to
2f6ae09
Compare
- Remove databricks-openai from test deps (breaks core_test lowest-direct) - Use pytest.importorskip instead - Convert print() to logging in deploy script - Fix ruff/format issues in all OBO files - Remove hardcoded warehouse ID, use env var Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The serving endpoint returns the SP's UUID via SQL current_user(), not the display_name. Use the client ID from env var which matches. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These are model artifacts and deploy scripts that use MLflow/agents types not available in the core type checking environment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The serving env doesn't have OBO_TEST_WAREHOUSE_ID. The deploy script now replaces the placeholder in the agent file before logging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…serving Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
agents.deploy() auto-derives endpoint name from UC model name. Passing endpoint_name was creating a new endpoint instead of updating the existing one. Match notebook pattern exactly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aravind-segu
reviewed
Mar 6, 2026
Contributor
aravind-segu
left a comment
There was a problem hiding this comment.
Couple comments but looks good overall. Can I also get the url to the jobs in the workspace.
tests/integration_tests/obo/model_serving_fixture/whoami_serving_agent.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Relevant links to compute @aravind-segu : Model Serving Endpoint: https://ai-oss-ecosystem-integration-testing.cloud.databricks.com/ml/endpoints/agents_integration_testing-databricks_ai_bridge_mcp_test-test_e?o=3272836215725701 Relevant links to Job Runs in ai-oss CI: OBO Test CI: https://github.com/databricks-eng/ai-oss-integration-tests-runner/actions/runs/22786939289 Model Serving Re-deploy CI: https://github.com/databricks-eng/ai-oss-integration-tests-runner/actions/runs/22694859161 |
- Consolidate invoke/stream into create_whoami_agent() helper - Use auth_type="pat" instead of env var pop/restore hack - Increase SQL warehouse wait_timeout to 120s for cold starts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Increase warmup from 10 to 20 attempts (10 min total) - Poll endpoint state via SDK before sending expensive LLM requests - Only send real request once endpoint reports READY Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4997076 to
96e6b72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whoami()UC function toolModelServingUserCredentialsdocstring (credential_strategy→credentials_strategy)Test plan