Track zstd-compressed resource state sizes in deploy telemetry (direct engine)#5604
Closed
shreyas-goenka wants to merge 1 commit into
Closed
Conversation
…t engine)
Deploy telemetry already reports per-resource-type raw state-size statistics
(state_size_{max,mean,median}_bytes). The deployment metadata service stores
that same per-resource state zstd-compressed, so this adds the compressed-size
counterparts to gauge how much resource state shrinks under compression rather
than just the raw sizes:
- state_compressed_size_max_bytes
- state_compressed_size_mean_bytes
- state_compressed_size_median_bytes
The compressed length is computed once per resource at state-export time
(alongside the existing raw length), using github.com/klauspost/compress/zstd.
Only the direct engine is measured, matching the existing raw-size behavior.
The acceptance golden masks the compressed values (COMPRESSED_SIZE) because
they depend on the klauspost/compress version, like state_file_size_bytes is
dropped for embedding the CLI version; the dstate unit test covers real
compression behavior.
Co-authored-by: Isaac
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
Superseded by #5608, which has the branch on databricks/cli directly so CI (which needs OIDC/secrets, unavailable to fork PRs) can run. Same change, now using stdlib compress/flate instead of a zstd dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bundle deploy telemetry already reports per-resource-type raw state-size statistics (
state_size_{max,mean,median}_bytesinResourceMetadata). The same per-resource state is stored zstd-compressed downstream, so this adds the compressed-size counterparts to gauge how much resource state shrinks under compression, not just the raw sizes:state_compressed_size_max_bytesstate_compressed_size_mean_bytesstate_compressed_size_median_bytes