Simplify bundle JSON schema annotation system#4670
Draft
shreyas-goenka wants to merge 4 commits intomainfrom
Draft
Simplify bundle JSON schema annotation system#4670shreyas-goenka wants to merge 4 commits intomainfrom
shreyas-goenka wants to merge 4 commits intomainfrom
Conversation
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik,
pietern and
simonfaltum
as code owners
shreyas-goenka
force-pushed
the
simplify-schema-annotations
branch
from
680bea6 to
f79f5b0
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 6225f44
33 interesting tests: 10 flaky, 8 FAIL, 7 KNOWN, 7 SKIP, 1 BUG
Top 20 slowest tests (at least 2 minutes):
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Read OpenAPI descriptions directly from the spec at runtime instead of pre-extracting them into annotation YAML files. This makes the OpenAPI spec a requirement for schema generation and eliminates annotation files that flip-flopped on every SDK bump. Changes: - Remove annotations_openapi.yml and annotations_openapi_overrides.yml - Merge manual overrides into a single annotations.yml - Use bundle paths (e.g. resources.jobs.*) as annotation keys instead of Go type paths - Add path_mapping.go to resolve bundle paths to Go types via reflection - Remove bundle/docsgen (was the only other consumer of annotations) - Makefile schema targets now require DATABRICKS_OPENAPI_SPEC Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix copyloopvar lint warnings in annotations.go - Fix gofmt issue in path_mapping_test.go - Use maps.Copy instead of manual loop - Restore permission level enums, lifecycle descriptions, markdownDescription, and SDK type overrides from the deleted annotations_openapi_overrides.yml into annotations.yml - Update getOpenApiAnnotations to check embedded types for promoted field descriptions from OpenAPI spec - Update TestNoDetachedAnnotations to handle Go type path keys Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…qlWarehouse, and SDK types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
After rebase on main, adapt to #4666 which switched grants from custom per-resource types to SDK catalog.PrivilegeAssignment. Remove stale per-resource grant annotation entries (descriptions now come from OpenAPI), regenerate schema and python codegen, and clean up .wsignore references to deleted docsgen files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
force-pushed
the
simplify-schema-annotations
branch
from
2f2a2d7 to
6225f44
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
annotations_openapi.ymlandannotations_openapi_overrides.ymlwhich flip-flopped on every SDK bump. Merge manual overrides into a singleannotations.yml.resources.jobs.*) as annotation keys instead of Go type paths.bundle/docsgen. It was never used beyond the initial documentation scaffolding for our public docs.Test plan
🤖 Generated with Claude Code