[Feature] Add support for Unified Host with experimental flag#4260
Merged
[Feature] Add support for Unified Host with experimental flag#4260
Conversation
tanmay-db
requested review from
alexott,
andrewnester,
anton-107,
denik,
nfx,
pietern and
shreyas-goenka
as code owners
tanmay-db
removed request for
alexott,
andrewnester,
anton-107,
denik,
nfx,
pietern and
shreyas-goenka
tanmay-db
changed the title
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: be536d3
32 interesting tests: 14 flaky, 7 KNOWN, 5 SKIP, 4 RECOVERED, 2 BUG
Top 50 slowest tests (at least 2 minutes):
|
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
changed the title
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
changed the title
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
approved these changes
Jan 16, 2026
denik
reviewed
Jan 19, 2026
| var authArguments auth.AuthArguments | ||
| cmd.PersistentFlags().StringVar(&authArguments.Host, "host", "", "Databricks Host") | ||
| cmd.PersistentFlags().StringVar(&authArguments.AccountID, "account-id", "", "Databricks Account ID") | ||
| cmd.PersistentFlags().BoolVar(&authArguments.IsUnifiedHost, "experimental-is-unified-host", false, "Flag to indicate if the host is a unified host") |
Contributor
There was a problem hiding this comment.
question - can we reliably determine if host is unified based on regex on host? Then we don't need to ask users that and there is no risk of mismatch.
Contributor
There was a problem hiding this comment.
Just found this: databricks/databricks-sdk-go#1403 it looks like this flag is going to be removed?
Contributor
Author
There was a problem hiding this comment.
Hi @denik , we have taken the decision to keep the flag for now and not rely on regex as there are a number of use cases that will not be supported (dependent on cloud etc...) so we keep the usage of unified host as opt-in to set the right expectations.
The second PR is a PoC based on the internal pattern matching, it is not going to be merged for now. In future we would have support for cloud agnostic hosts so the flag won't be required at that time.
Contributor
|
Please include relevant PRs on SDK side in the description. I found these databricks/databricks-sdk-go#1307 (depends on) databricks/databricks-sdk-go#1403 (not used yet, but should be?) |
Contributor
Author
|
Thanks for the review @denik, added the relevant PR in the description. |
denik
approved these changes
Jan 19, 2026
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Author
Thanks @denik added. |
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Jan 21, 2026
| func promptForWorkspaceID(ctx context.Context) (string, error) { | ||
| if !cmdio.IsPromptSupported(ctx) { | ||
| // Workspace ID is optional for unified hosts, so return empty string in non-interactive mode | ||
| return "", nil |
Contributor
There was a problem hiding this comment.
Why is it optional? If I understand correctly, we cannot make API calls without a workspace ID.
Contributor
There was a problem hiding this comment.
And then this should return an error.
Contributor
Author
There was a problem hiding this comment.
This is optional because without workspace ID we configure the client for account to make account requests.
Contributor
There was a problem hiding this comment.
Does the caller error if neither an account ID nor a workspace ID is specified?
Contributor
Author
There was a problem hiding this comment.
Yes
Error: fetching oauth config: fetching OAuth endpoints: failed to get OAuth endpoints: received HTML response instead of JSON
Contributor
There was a problem hiding this comment.
That's not actionable. I was thinking of a proper error saying that you need either an account ID or a workspace ID.
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 5c0467c
29 interesting tests: 13 flaky, 7 KNOWN, 5 SKIP, 4 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
This support is required for enabling unified hosts which Databricks free edition uses.
Tests
databricks auth login --host <spog-host> --experimental-is-unified-hostprompts for account and workspace id followed by opening web browser. The IDs and flag is stores in the config. The subsequent cli operations eg: databricks clusters list --profile "above-profile" works.